A Pull Request (PR) is how you say: "Hey team, I wrote some tests. Please review my code before I merge it into main." It's the professional way to add code. No PR = no merge. That's the rule in every serious team.
Why? Because a bad test in main breaks the CI pipeline. A flaky test wastes everyone's time. A locator with a typo fails at 2 AM and pages the on-call dev. Code review catches these problems before they reach main.
## What this PR does
- Adds login test cases (valid login, invalid password, empty fields)
- Creates LoginPage page object with locators and methods
- Adds @Step annotations for Allure reporting
## Test results
- All 5 new tests pass locally
- Existing regression suite passes (42/42)
## Checklist
- [x] Tests pass locally
- [x] Page objects follow naming convention
- [x] No hardcoded test data
- [x] .gitignore updated if neededNever merge your own PR without at least one review. Even senior automation engineers get their PRs reviewed. A second pair of eyes catches things you miss.
Q: What is a Pull Request and why is it important?
A: A Pull Request is a request to merge code from one branch into another on GitHub. It shows exactly what files changed and lets team members review the code before it gets merged. For QA teams, PRs are critical because they catch issues like fragile locators, missing waits, flaky test patterns, hardcoded test data, and duplicate test coverage before these problems reach the main branch. We have a rule — no PR gets merged without at least one approval.
Key Point: Pull Requests are your team's safety net. Every test you write gets reviewed before it reaches main.